Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of game reveal doesn't show correct roles #157

Open
twchapman opened this issue Jul 8, 2024 · 5 comments
Open

End of game reveal doesn't show correct roles #157

twchapman opened this issue Jul 8, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@twchapman
Copy link

Description:

After the game ended and player roles were revealed, it incorrectly showed me as the lone Liberal and everyone else in the game as Fascist.

image

Reproduction:

It only happened once so I don't have repro steps, but I was told by others this has happened before.

@twchapman
Copy link
Author

Also I realize this repo isn't super active anymore, I just wanted to log it in case someone (maybe me??) finds time.

@ShrimpCryptid
Copy link
Owner

ShrimpCryptid commented Jul 8, 2024

Also I realize this repo isn't super active anymore, I just wanted to log it in case someone (maybe me??) finds time.

Oops, that someone should be me. Thanks for noting the bug!

The development branch converts a bunch of the project to Typescript, but hasn't been made live yet due to some stability issues. I think this bug gets fixed as part of that change, but there's also a new related bug, #140, where player roles are shown too early.

@ShrimpCryptid ShrimpCryptid self-assigned this Jul 8, 2024
@ShrimpCryptid ShrimpCryptid added the bug Something isn't working label Jul 8, 2024
@twchapman
Copy link
Author

Cool, good to know! Adding Typescript is super helpful when it's all done, but such a pain to develop sometimes. 😁

@furrykef
Copy link

I played only one game online against bots and this happened to me too. I was shown as the only liberal and no Hitler was shown. Kinda puts a damper on the whole thing because I have no idea if I've correctly identified any fascists.

@ShrimpCryptid
Copy link
Owner

I played only one game online against bots and this happened to me too. I was shown as the only liberal and no Hitler was shown. Kinda puts a damper on the whole thing because I have no idea if I've correctly identified any fascists.

Thanks for the comment, and I'm sorry you're still encountering that. There's a bunch of work I need to do to get the Typescript refactor ready and I haven't had a lot of time to put on this project 😬

I'll consider adding a patch just to fix that issue on the current production build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: New
Development

No branches or pull requests

3 participants