feat(agent): Implement more tolerant json_loads function
#7016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Do you have benchmark stats for this? I’d like to see if it improves our score much |
Pwuts
reviewed
Mar 14, 2024
autogpts/autogpt/autogpt/core/planning/prompt_strategies/initial_plan.py
Outdated
Show resolved
Hide resolved
And sort dependencies in `pyproject.toml` alphabetically.
Pwuts
requested changes
Mar 18, 2024
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
added
the
conflicts
Pwuts
previously approved these changes
Mar 20, 2024
Pwuts
changed the title
json_loads functionjson_loads function
…ctly-formatted-json-jsondecodeerror
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
conflicts
Pwuts
changed the title
json_loads functionjson_loads function
kcze
deleted the
kpczerwinski/open-183-llm-returned-incorrectly-formatted-json-jsondecodeerror
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPEN-183
Background
OpenAI API tends to return broken json responses (such as trailing commas, extra newlines) which fail to be parsed by built-in
json.loads.This change introduces relaxed parsing function
json_loadsusingdemjson3that handles minor syntax issues in json and is used wherejson.loadswas used previously to parse responses from llm.It can deal with:
Changes 🏗️
demjson3 ^3.0.0(LGPLv3 license)json_loadsfunctionjson.loadswithjson_loadsacross multiple files