Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fixes #1

Open
patsperca opened this issue Dec 30, 2021 · 1 comment
Open

Minor Fixes #1

patsperca opened this issue Dec 30, 2021 · 1 comment

Comments

@patsperca
Copy link

First of all, thanks for sharing your implementation of the nanoleaf API!
I am currently implementing the tiles in my custom smart home solution and found it very useful.

After playing around i ran in to some issues i'd like to share with you:
First of all, it would be good to ensure that the correct TCP port (16021) is used when initally connecting to your tiles, this gave me some headache...

I am not fully through my integration tests but found out that String Literal escaping was not working and fixed it mainly in replacing all the places where ' is used instead of " .

If you like i would share my tweaks of the code with you and help to build an nuget package once everything works as expected.

@Silverdark
Copy link
Owner

Thanks for the nice words 😄

First of all, it would be good to ensure that the correct TCP port (16021) is used when initally connecting to your tiles, this gave me some headache...

Can the port be configured? This is free configurable by intention to restrict as few as possible (maybe someone else is using a proxy or something else with a different port).

I am not fully through my integration tests but found out that String Literal escaping was not working and fixed it mainly in replacing all the places where ' is used instead of " .

This sounds interesting, would like to know more about it.

If you like you can create a Pull Request and I will look into it. The NuGet package will be created automatically like the last version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants