Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled breaking change in v2.1.0 #425

Closed
fstof opened this issue Apr 22, 2024 · 2 comments · Fixed by #427
Closed

Unhandled breaking change in v2.1.0 #425

fstof opened this issue Apr 22, 2024 · 2 comments · Fixed by #427

Comments

@fstof
Copy link

fstof commented Apr 22, 2024

Describe the bug
Updating to the latest version (2.1.0) is breaking stuff on our side as the use of ViewPadding is not available on previous versions of Dart SDK

To Reproduce
Steps to reproduce the behavior:

  1. Create flutter project with dart "sdk < 3"
  2. include showcaseview: 2.1.0
  3. running app should fail as reference to ViewPadding.zero does not exist

Expected behavior
Should work

Additional context
The latest version of this sdk should version the latest release as a "breaking change" version update (3.0.0) as well as updating the minimum sdk version to > 3.0.0 so dependants don't fail if pubspecs reference ^2.0.0

Ideally a working (fixed)version should be published under the 2.x.x version in order to fix breaking dependencies then a new major version can be published with new changes

@aditya-css
Copy link
Collaborator

Thank you @fstof for bringing this into our notice. It was a slip from our end, have created PR #427 with the fix. You can use that PR till we release a new version with that commit.

@fstof
Copy link
Author

fstof commented Apr 23, 2024

Thanks for this @aditya-css
Do we have an ETA for the release of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants