-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set version_info/version in install_as_pycairo #10
Comments
Hi. Thanks for the bug report. I just made a change, does it fix the issue for you? (Please try the git version.) |
Well, that sucks. I put the cairocffi version number in there but matplotlib probably does comparison with some known pycairo version, so it's not gonna work. Ideally they should really do feature detection rather than version detection. Do you have some idea of what features/versions they expect? Maybe try raising an issue on matplotlib? I'd rather not make up a "pycairo-equivalent" version number. It would make sense: the feature set of pycairo and cairocffi are neither quite a subset of the other. |
No, doesn't work. It expects (1, 2, 0) (it should be tuple of ints, not a list of strings btw). What do you think about installing a proxy module in |
OK, try this now. I don't really like where this is going but I changed it to 1.10.0 and tuple-of-ints as you suggested. I'm not sure a module proxy would really help. TODO for me: document this. |
Thanks. |
I take it this resolved the issue with Matplotlib? |
Yes. |
fwiw I'm going to bump mpl's min pycairo version to 1.11.0 and make the check only happen for pycairo, not cairocffi, so this hack may be removed (once mpl is fixed)... |
I'm playing around with matplotlib atm, which uses
version_info
andversion
to check if the installed pycairo is recent enough.I suggest adding something like this in
install_as_pycairo()
:The text was updated successfully, but these errors were encountered: