From 9b07771caccb8c23b28ab5bb2a5f677c07e042ad Mon Sep 17 00:00:00 2001 From: Bryce Van Dyk <bryce@vandyk.net.nz> Date: Thu, 21 Jan 2021 15:42:07 -0500 Subject: [PATCH] Remove lines allowing clippy cognitive complexity checks. Since these allow lines were added, this clippy lint has been downgraded to a nursery check via https://github.com/rust-lang/rust-clippy/pull/5428 Since we don't have allows for other nursery lints, I suggest we remove these ones. --- mp4parse/tests/public.rs | 5 ----- mp4parse_capi/tests/test_encryption.rs | 1 - 2 files changed, 6 deletions(-) diff --git a/mp4parse/tests/public.rs b/mp4parse/tests/public.rs index 42a4c42b..90dbfed9 100644 --- a/mp4parse/tests/public.rs +++ b/mp4parse/tests/public.rs @@ -41,7 +41,6 @@ static AVIF_CORRUPT_IMAGES: &str = "tests/corrupt"; // Adapted from https://github.com/GuillaumeGomez/audio-video-metadata/blob/9dff40f565af71d5502e03a2e78ae63df95cfd40/src/metadata.rs#L53 #[test] -#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this fn public_api() { let mut fd = File::open(MINI_MP4).expect("Unknown file"); let mut buf = Vec::new(); @@ -161,7 +160,6 @@ fn public_api() { } #[test] -#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this fn public_metadata() { let mut fd = File::open(MINI_MP4_WITH_METADATA).expect("Unknown file"); let mut buf = Vec::new(); @@ -228,7 +226,6 @@ fn public_metadata() { } #[test] -#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this fn public_metadata_gnre() { let mut fd = File::open(MINI_MP4_WITH_METADATA_STD_GENRE).expect("Unknown file"); let mut buf = Vec::new(); @@ -486,7 +483,6 @@ fn public_audio_cbcs() { } #[test] -#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this fn public_video_cbcs() { let system_id = vec![ 0x10, 0x77, 0xef, 0xec, 0xc0, 0xb2, 0x4d, 0x02, 0xac, 0xe3, 0x3c, 0x1e, 0x52, 0xe2, 0xfb, @@ -567,7 +563,6 @@ fn public_video_cbcs() { } #[test] -#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this fn public_video_av1() { let mut fd = File::open(VIDEO_AV1_MP4).expect("Unknown file"); let mut buf = Vec::new(); diff --git a/mp4parse_capi/tests/test_encryption.rs b/mp4parse_capi/tests/test_encryption.rs index 33c9c6d9..fe911403 100644 --- a/mp4parse_capi/tests/test_encryption.rs +++ b/mp4parse_capi/tests/test_encryption.rs @@ -12,7 +12,6 @@ extern "C" fn buf_read(buf: *mut u8, size: usize, userdata: *mut std::os::raw::c } #[test] -#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this fn parse_cenc() { let mut file = std::fs::File::open("tests/short-cenc.mp4").expect("Unknown file"); let io = Mp4parseIo {