From 908585a3eb0cfd441cdbcaf9852fa922bcab17ef Mon Sep 17 00:00:00 2001
From: Jean-Yves Moyen <jym@siteimprove.com>
Date: Tue, 14 Nov 2023 09:39:45 +0100
Subject: [PATCH] Remove unused question (#1497)

* Remove unused question

* Extract documentation
---
 .changeset/strange-hairs-share.md              | 5 +++++
 docs/review/api/alfa-rules.api.md              | 6 ------
 packages/alfa-rules/src/common/act/question.ts | 5 -----
 packages/alfa-rules/test/common/oracle.ts      | 3 ---
 4 files changed, 5 insertions(+), 14 deletions(-)
 create mode 100644 .changeset/strange-hairs-share.md

diff --git a/.changeset/strange-hairs-share.md b/.changeset/strange-hairs-share.md
new file mode 100644
index 0000000000..a5fec3b336
--- /dev/null
+++ b/.changeset/strange-hairs-share.md
@@ -0,0 +1,5 @@
+---
+"@siteimprove/alfa-rules": minor
+---
+
+**Breaking:** Question `visible-focus-classes`, and question type `string[]` have been removed.
diff --git a/docs/review/api/alfa-rules.api.md b/docs/review/api/alfa-rules.api.md
index f83daf40b6..676f322c57 100644
--- a/docs/review/api/alfa-rules.api.md
+++ b/docs/review/api/alfa-rules.api.md
@@ -180,8 +180,6 @@ export namespace Question {
         // (undocumented)
         "node[]": Iterable<Node>;
         // (undocumented)
-        "string[]": Iterable<string>;
-        // (undocumented)
         boolean: boolean;
         // (undocumented)
         node: Option<Node>;
@@ -272,10 +270,6 @@ export namespace Question {
             readonly type: "boolean";
             readonly message: "Do these [role] landmarks have the same or equivalent content?";
         };
-        readonly "visible-focus-classes": {
-            readonly type: "string[]";
-            readonly message: "Which classes have a visible focus indicator?";
-        };
         readonly "has-focus-indicator": {
             readonly type: "boolean";
             readonly message: "Does the element have a visible focus indicator?";
diff --git a/packages/alfa-rules/src/common/act/question.ts b/packages/alfa-rules/src/common/act/question.ts
index 31283a2614..423e87be86 100644
--- a/packages/alfa-rules/src/common/act/question.ts
+++ b/packages/alfa-rules/src/common/act/question.ts
@@ -17,7 +17,6 @@ export namespace Question {
     "node[]": Iterable<Node>;
     "color[]": Iterable<RGB>;
     string: string;
-    "string[]": Iterable<string>;
   }
 
   type TypeName<U extends Uri> = Data[U]["type"];
@@ -188,10 +187,6 @@ export namespace Question {
       message: `Do these [role] landmarks have the same or equivalent content?`,
     },
     // R65
-    "visible-focus-classes": {
-      type: "string[]",
-      message: `Which classes have a visible focus indicator?`,
-    },
     "has-focus-indicator": {
       type: "boolean",
       message: `Does the element have a visible focus indicator?`,
diff --git a/packages/alfa-rules/test/common/oracle.ts b/packages/alfa-rules/test/common/oracle.ts
index b7d69a0cd2..5c380fbde0 100644
--- a/packages/alfa-rules/test/common/oracle.ts
+++ b/packages/alfa-rules/test/common/oracle.ts
@@ -54,9 +54,6 @@ export function oracle<I, T extends Hashable, S>(
 
       case "string":
         return wrapper(question, answers[question.uri]!);
-
-      case "string[]":
-        return wrapper(question, answers[question.uri]!);
     }
   };
 }