Rename tree.Node#serializationId to tree.Node#internalId.

[Jym77]

This makes it a bit more general.

[changeset-bot]

🦋 Changeset detected

Latest commit: 3e6755b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 77 packages

Name	Type
@siteimprove/alfa-rules	Minor
@siteimprove/alfa-tree	Minor
@siteimprove/alfa-dom	Minor
@siteimprove/alfa-aria	Minor
@siteimprove/alfa-cascade	Minor
@siteimprove/alfa-selector	Minor
@siteimprove/alfa-style	Minor
@siteimprove/alfa-table	Minor
@siteimprove/alfa-web	Minor
@siteimprove/alfa-xpath	Minor
@siteimprove/alfa-act	Minor
@siteimprove/alfa-affine	Minor
@siteimprove/alfa-applicative	Minor
@siteimprove/alfa-array	Minor
@siteimprove/alfa-bits	Minor
@siteimprove/alfa-branched	Minor
@siteimprove/alfa-cache	Minor
@siteimprove/alfa-callback	Minor
@siteimprove/alfa-clone	Minor
@siteimprove/alfa-collection	Minor
@siteimprove/alfa-comparable	Minor
@siteimprove/alfa-compatibility	Minor
@siteimprove/alfa-continuation	Minor
@siteimprove/alfa-css-feature	Minor
@siteimprove/alfa-css	Minor
@siteimprove/alfa-device	Minor
@siteimprove/alfa-earl	Minor
@siteimprove/alfa-either	Minor
@siteimprove/alfa-emitter	Minor
@siteimprove/alfa-encoding	Minor
@siteimprove/alfa-equatable	Minor
@siteimprove/alfa-flags	Minor
@siteimprove/alfa-fnv	Minor
@siteimprove/alfa-foldable	Minor
@siteimprove/alfa-functor	Minor
@siteimprove/alfa-future	Minor
@siteimprove/alfa-generator	Minor
@siteimprove/alfa-graph	Minor
@siteimprove/alfa-hash	Minor
@siteimprove/alfa-http	Minor
@siteimprove/alfa-iana	Minor
@siteimprove/alfa-iterable	Minor
@siteimprove/alfa-json-ld	Minor
@siteimprove/alfa-json	Minor
@siteimprove/alfa-lazy	Minor
@siteimprove/alfa-list	Minor
@siteimprove/alfa-map	Minor
@siteimprove/alfa-mapper	Minor
@siteimprove/alfa-math	Minor
@siteimprove/alfa-monad	Minor
@siteimprove/alfa-network	Minor
@siteimprove/alfa-option	Minor
@siteimprove/alfa-parser	Minor
@siteimprove/alfa-performance	Minor
@siteimprove/alfa-predicate	Minor
@siteimprove/alfa-promise	Minor
@siteimprove/alfa-record	Minor
@siteimprove/alfa-rectangle	Minor
@siteimprove/alfa-reducer	Minor
@siteimprove/alfa-refinement	Minor
@siteimprove/alfa-result	Minor
@siteimprove/alfa-sarif	Minor
@siteimprove/alfa-selective	Minor
@siteimprove/alfa-sequence	Minor
@siteimprove/alfa-set	Minor
@siteimprove/alfa-slice	Minor
@siteimprove/alfa-string	Minor
@siteimprove/alfa-test	Minor
@siteimprove/alfa-thenable	Minor
@siteimprove/alfa-thunk	Minor
@siteimprove/alfa-time	Minor
@siteimprove/alfa-toolchain	Minor
@siteimprove/alfa-trampoline	Minor
@siteimprove/alfa-trilean	Minor
@siteimprove/alfa-tuple	Minor
@siteimprove/alfa-url	Minor
@siteimprove/alfa-wcag	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Jym77]

!pr extract

[Jym77]

@jfer-siteimprove @mvy-siteimprove FYI. I believe this will break the Code Checker Page Report that only receives the JSON serialization and thus need to read the correct field name.

[mvy-siteimprove]

@jfer-siteimprove @mvy-siteimprove FYI. I believe this will break the Code Checker Page Report that only receives the JSON serialization and thus need to read the correct field name.

Thanks for the heads up @Jym77. Good that the serializationId is still available as an alias. We can safely deploy this, update our usage and then delete the alias.

[Jym77]

@jfer-siteimprove @mvy-siteimprove FYI. I believe this will break the Code Checker Page Report that only receives the JSON serialization and thus need to read the correct field name.

Thanks for the heads up @Jym77. Good that the serializationId is still available as an alias. We can safely deploy this, update our usage and then delete the alias.

🤔 I am not sure because you only read the JSON, not the actual object.
Or should I keep the serializationId alias in the JSON too?

[Jym77]

@jfer-siteimprove @mvy-siteimprove FYI. I believe this will break the Code Checker Page Report that only receives the JSON serialization and thus need to read the correct field name.

Thanks for the heads up @Jym77. Good that the serializationId is still available as an alias. We can safely deploy this, update our usage and then delete the alias.

🤔 I am not sure because you only read the JSON, not the actual object. Or should I keep the serializationId alias in the JSON too?

Should be good now ☺️