Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuantizeProcessor does not use sourceRectangle #633

Closed
4 tasks done
Jjagg opened this issue Jun 25, 2018 · 1 comment
Closed
4 tasks done

QuantizeProcessor does not use sourceRectangle #633

Jjagg opened this issue Jun 25, 2018 · 1 comment

Comments

@Jjagg
Copy link
Contributor

Jjagg commented Jun 25, 2018

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of ImageSharp
  • I have verified if the problem exist in both DEBUG and RELEASE mode
  • I have searched open and closed issues to ensure it has not already been reported

Description

Title says it all. The OnFrameApply method in QuantizeProcessor does not use the sourceRectangle it gets.

To resolve this the following methods need to support a sourceRectangle:

  • IFrameQuantizer<TPixel>.QuantizeFrame
  • FrameQuantizerBase<TPixel>.FirstPass and SecondPass

System Configuration
@Jjagg Jjagg mentioned this issue Jun 26, 2018
Closed
3 tasks
@JimBobSquarePants
Copy link
Member

I forgot we'd added this functionality. Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JimBobSquarePants @Jjagg