You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the config is saved as SkyblockCoreConfig.json, which is already in conflict with our naming scheme and should be SkyBlockCoreConfig.json if we're keeping that style.
Some users have proposed we change the naming style to camelCase instead. We should have a quick discussion about which is preferred, or if we should have another change altogether.
Config Classes
The files ModConfig.java and ConfigManager.java are both stored in the events package - I don't feel like this is a good design, they should probably have their own package (config?) or be moved somewhere more fitting (even the util package is a better fit).
Also, personally - I'm unsure of the name ModConfig considering we've decided this shouldn't be treated as a standalone mod. New class names for that are also being accepted.
Checklist
Decide on a new naming convention for the config
Rename the config
Decide which package the config files belong in and/or if they should be renamed
Move the config files to the new package (and possibly rename them too)
The text was updated successfully, but these errors were encountered:
I think we should rename the config file to SkyBlockCoreConfig
I think we should move it to a new package that would be called config or something along the lines of that
I think we should rename the class and the file as well too to SkyBlockCoreConfigManager (maybe) or something along the lines if that is too long
And the same for ModConfig rename the file and class to something along the lines of SkyBlockCoreConfig(no conflict with real config bc java and json right?)
I think we should rename the config file to SkyBlockCoreConfig
I think we should move it to a new package that would be called config or something along the lines of that
I think we should rename the class and the file as well too to SkyBlockCoreConfigManager (maybe) or something along the lines if that is too long
And the same for ModConfig rename the file and class to something along the lines of SkyBlockCoreConfig(no conflict with real config bc java and json right?)
Config File
Currently the config is saved as
SkyblockCoreConfig.json
, which is already in conflict with our naming scheme and should beSkyBlockCoreConfig.json
if we're keeping that style.Some users have proposed we change the naming style to
camelCase
instead. We should have a quick discussion about which is preferred, or if we should have another change altogether.Config Classes
The files
ModConfig.java
andConfigManager.java
are both stored in theevents
package - I don't feel like this is a good design, they should probably have their own package (config
?) or be moved somewhere more fitting (even theutil
package is a better fit).Also, personally - I'm unsure of the name
ModConfig
considering we've decided this shouldn't be treated as a standalone mod. New class names for that are also being accepted.Checklist
The text was updated successfully, but these errors were encountered: