Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Changes - File Structure #31

Open
4 tasks
TGWaffles opened this issue Jun 15, 2023 · 2 comments
Open
4 tasks

Config Changes - File Structure #31

TGWaffles opened this issue Jun 15, 2023 · 2 comments

Comments

@TGWaffles
Copy link
Member

TGWaffles commented Jun 15, 2023

Config File

Currently the config is saved as SkyblockCoreConfig.json, which is already in conflict with our naming scheme and should be SkyBlockCoreConfig.json if we're keeping that style.

Some users have proposed we change the naming style to camelCase instead. We should have a quick discussion about which is preferred, or if we should have another change altogether.

Config Classes

The files ModConfig.java and ConfigManager.java are both stored in the events package - I don't feel like this is a good design, they should probably have their own package (config?) or be moved somewhere more fitting (even the util package is a better fit).

Also, personally - I'm unsure of the name ModConfig considering we've decided this shouldn't be treated as a standalone mod. New class names for that are also being accepted.

Checklist

  • Decide on a new naming convention for the config
  • Rename the config
  • Decide which package the config files belong in and/or if they should be renamed
  • Move the config files to the new package (and possibly rename them too)
@Zickles
Copy link
Contributor

Zickles commented Jun 15, 2023

  1. I think we should rename the config file to SkyBlockCoreConfig
  2. I think we should move it to a new package that would be called config or something along the lines of that
  3. I think we should rename the class and the file as well too to SkyBlockCoreConfigManager (maybe) or something along the lines if that is too long
  4. And the same for ModConfig rename the file and class to something along the lines of SkyBlockCoreConfig(no conflict with real config bc java and json right?)

@UnexDev
Copy link

UnexDev commented Oct 3, 2023

  1. I think we should rename the config file to SkyBlockCoreConfig

    1. I think we should move it to a new package that would be called config or something along the lines of that

    2. I think we should rename the class and the file as well too to SkyBlockCoreConfigManager (maybe) or something along the lines if that is too long

    3. And the same for ModConfig rename the file and class to something along the lines of SkyBlockCoreConfig(no conflict with real config bc java and json right?)

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants