diff --git a/.github/scripts/check_icon_pr.py b/.github/scripts/check_icon_pr.py index 1c8d8376c..a5842dffa 100644 --- a/.github/scripts/check_icon_pr.py +++ b/.github/scripts/check_icon_pr.py @@ -22,7 +22,7 @@ def main(): pr_err_msg = "" pr_data = api_handler.get_pull_req(args.token, args.pr_number) pr_base_branch = api_handler.get_pr_base_branch(pr_data) - if not pr_base_branch != "develop": + if pr_base_branch != "develop": pr_err_msg.append(f"The PR's base branch is `{pr_base_branch}`, but should be `develop`, please change the PR so that it's based on, and merged into `develop`") all_icons = filehandler.get_json_file_content(args.devicon_json_path)