Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config.v8.yaml #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dericy
Copy link

@dericy dericy commented Mar 11, 2024

Fixes #18. Still need to look at the tests for both snakemake <8 and >8. I guess I could add a matrix for the github actions but I'm not sure the best way beyond tox of going about doing it locally. I also use podman which doesn't have docker-swarm which makes it difficult to test locally. It seems to work on the cluster I use at least.

@dericy dericy force-pushed the master branch 2 times, most recently from b7d872a to 7942789 Compare March 12, 2024 17:58
@jheuel
Copy link
Collaborator

jheuel commented Mar 22, 2024

I added the test matrix over Snakemake versions <8 and >=8. Can you test if your changes work for both? The CI tests should run on push.

@jannisspeer
Copy link

I wrote a snakemake executor plugin for htcondor pypi which you could add to the config.v8.yaml instead of the generic-executor plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with Snakemake >= 8
3 participants