Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Add reference symbol for embind methods #126

Open
paulocoutinhox opened this issue Dec 25, 2022 · 0 comments
Open

[suggestion] Add reference symbol for embind methods #126

paulocoutinhox opened this issue Dec 25, 2022 · 0 comments

Comments

@paulocoutinhox
Copy link
Contributor

Hi,

The current bind code is:

EMSCRIPTEN_BINDINGS(nativium_core_application_core) {
    em::class_<::nativium::core::ApplicationCore>("ApplicationCore")
        .smart_ptr<std::shared_ptr<::nativium::core::ApplicationCore>>("ApplicationCore")
        .function("nativeDestroy", &NTVCoreApplicationCore::nativeDestroy)
        .class_function("shared", NTVCoreApplicationCore::shared)
        .function("multiply", NTVCoreApplicationCore::multiply)
        .function("getVersion", NTVCoreApplicationCore::getVersion)
        ;
}

But on documentation, all functions need have the & symbol.

See on documentation:
https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#classes

Can we change to this?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant