Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @return annotation for getCustomerGroups() #332

Closed
chrisastley opened this issue Aug 6, 2024 · 3 comments
Closed

Missing @return annotation for getCustomerGroups() #332

chrisastley opened this issue Aug 6, 2024 · 3 comments

Comments

@chrisastley
Copy link
Contributor

An issue was introduced in the latest version preventing me from loading Swagger, not sure if the problem causes any other issues.

Method's return type must be specified using @return annotation. See Snowdog\Menu\Api\Data\NodeInterface::getCustomerGroups()

@chrisastley
Copy link
Contributor Author

I've added a pull request #333 but please check it is the correct return, it does solve the issue I have though.

@andrzejborkowski
Copy link

Thank you for reporting the issue, I've created an internal ticket DEV-106800 and our dev team will review your PR soon

@adamwaclawczyk
Copy link
Member

Thanks for spotting this so fast @chrisastley :)
I can imagine this was a real pain to find
2.27.1 should be available now with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants