Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variables width and height #337

Open
Morgy93 opened this issue Aug 14, 2024 · 2 comments
Open

Unused variables width and height #337

Morgy93 opened this issue Aug 14, 2024 · 2 comments

Comments

@Morgy93
Copy link

Morgy93 commented Aug 14, 2024

Hello,

there are some unused variables. Since I don't know the intention, I did not want to create a PR for removal only.


$imageWidth = $block->getImageWidth();
$imageHeight = $block->getImageHeight();

https://github.com/SnowdogApps/magento2-menu/blob/2.27.1/view/frontend/templates/hyva-menu-footer/menu/node_type/product.phtml


$imageWidth = $block->getImageWidth();
$imageHeight = $block->getImageHeight();

https://github.com/SnowdogApps/magento2-menu/blob/2.27.1/view/frontend/templates/hyva-topmenu-desktop/menu/node_type/product.phtml

@Morgy93
Copy link
Author

Morgy93 commented Aug 14, 2024

@andrzejborkowski
Copy link

hi @Morgy93,
thanks for reporting this issue! I created an internal ticket SMM-12 and our dev will check it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants