Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualified name availability in Resources and Data Sources #2035

Closed
TerjeRusska opened this issue Aug 29, 2023 · 3 comments
Closed

Qualified name availability in Resources and Data Sources #2035

TerjeRusska opened this issue Aug 29, 2023 · 3 comments
Labels
category:identifiers feature-request Used to mark issues with provider's missing functionalities resource:table Issue connected to the snowflake_table resource

Comments

@TerjeRusska
Copy link

Is your feature request related to a problem? Please describe.

Newer resources require the usage of qualified name which is not available in either existing resources or data sources. Example snowflake_table_column_masking_policy_application snowflake_grant_privileges_to_role.
Looping through these types of resources I have to build the qualified names myself from bits of available data.

resource snowflake_table_column_masking_policy_application masking_policy_sandbox {
  provider = snowflake.masking_admin
  for_each = local.masking_policy_sandbox

  # The qualified_name is in format "DATABASE"."SCHEMA"."TABLE"
  # FIXME: Take qualified_name from data source when it comes available
  table          = "\"${each.value.table.database}\".\"${each.value.table.schema}\".\"${each.value.table.name}\""
  column         = each.value.column
  masking_policy = "${each.value.table.database}.${each.value.table.schema}.MASKING_POLICY_${each.value.type}_${each.value.masking_policy}"
}

Describe the solution you'd like

Resources and Data sources should have qualified_name already available as a parameter

Describe alternatives you've considered

Currently manually building these qualified names

Additional context

@TerjeRusska TerjeRusska added the feature-request Used to mark issues with provider's missing functionalities label Aug 29, 2023
@sfc-gh-asawicki sfc-gh-asawicki added the resource:table Issue connected to the snowflake_table resource label Jun 13, 2024
@sfc-gh-jcieslak
Copy link
Collaborator

Hey @TerjeRusska 👋
In the next release, all resources will have a fully_qualified_name computed field. We decided not to add it to the data sources, but stay tuned, and after the release, let us know what you think. The change should be out somewhere around next week.

@sfc-gh-jcieslak
Copy link
Collaborator

Hey @TerjeRusska 👋
Yesterday we released version v0.95.0 of the provider that contains fully_qualified_name computed field for all resources (not applied to data sources).

@sfc-gh-jcieslak
Copy link
Collaborator

Closing due to long inactivity, from the emotes I assume you are happy with the results :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:identifiers feature-request Used to mark issues with provider's missing functionalities resource:table Issue connected to the snowflake_table resource
Projects
None yet
Development

No branches or pull requests

3 participants