Skip to content

Commit

Permalink
fix: Correct resolved to fulfilled (fixes #432)
Browse files Browse the repository at this point in the history
  • Loading branch information
RaceProUK committed Jul 5, 2017
1 parent c119e47 commit 07332a4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions test/lib/utilsTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@ describe('lib/utils', () => {
});
describe('iterate()', () => {
it('should resolve on empty input', () => {
return utils.iterate([]).should.eventually.resolve;
return utils.iterate([]).should.eventually.be.fulfilled;
});
it('should resolve on null input', () => {
return utils.iterate(null).should.eventually.resolve;
return utils.iterate(null).should.eventually.be.fulfilled;
});
it('should pass value to iterator', () => {
const spy = sinon.stub().resolves();
Expand Down
4 changes: 2 additions & 2 deletions test/providers/nodebb/indexTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -664,12 +664,12 @@ describe('providers/nodebb', () => {
};
});
it('should accept direct generation function', () => {
return forum.addPlugin(() => plug).should.be.resolved;
return forum.addPlugin(() => plug).should.be.fulfilled;
});
it('should accept indirect generation function', () => {
return forum.addPlugin({
plugin: () => plug
}).should.be.resolved;
}).should.be.fulfilled;
});
it('should add plugin to plugin list', () => {
forum._plugins = [5, 3, 4, 1, 2];
Expand Down
2 changes: 1 addition & 1 deletion test/providers/nodebb/notificationTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ describe('providers/nodebb/notification', () => {
it('should not reject when Post.preview rejects for non mention notification', () => {
data.type = 'not a mention';
forum.Post.preview.rejects('bad');
return notification.getText().should.be.resolved;
return notification.getText().should.be.fulfilled;
});
});
describe('url()', () => {
Expand Down

0 comments on commit 07332a4

Please sign in to comment.