-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Add Exceptions to Tasks #73
Comments
Happy to take thoughts on how the logging can be extended. It is currently pretty loud. Processing tasks from queue to happens here: Running of tasks happens here: The tasks the bot actually runs are defined round here: |
I meant exceptions we as dev can catch in our apps when using the discordbot-tasks. For issues like this: To allow us to do something like this: try:
aadiscordbot.tasks.send_channel_message_by_discord_id.delay(
rss_feed.discord_channel.channel,
discord_message,
embed=False,
)
except DiscordbotException as ex:
logger.debug(f"Something went wrong. {ex.message}") |
This can't be done with the current way we run tasks. The tasks you call in auth are simple shims. So the bot can manage it's rate limits 100% separately to auth. |
I can, and will add more logging tho. |
Add exceptions with error messages to the API functions like
send_channel_message_by_discord_id
,send_direct_message_by_discord_id
andsend_direct_message_by_user_id
so app devs can implement proper error handling when calling these tasks.Thank you!
The text was updated successfully, but these errors were encountered: