-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing ESlint reports shouldn't spam output with errors if no report found #1986
Comments
hi, I'm not expert in Azure DevOps (to put it mildly), from JavaScript analyzer side I have zero idea what could cause such behaviour. We certainly use report path as relative to project dir or absolute. I would suggest you to create a thread in https://community.sonarsource.com/, there is much more chance you will get the help there. thanks! |
sorry, I mixed the issues, this comment was meant for #1985 |
I'm not sure how Azure DevOps is really related to this? I've specified absolute paths in my config (e.g. |
@Bouke |
@vilchik-elena Well on linux it is, and on Windows the path separator would be |
tbh I'm hesitating to give you any advices as I have no idea what is going on in your logs. Theoretically we should simply iterate ONCE the list of paths set in the property. For each path we check if it's absolute (then we use it as it is), if relative we concatenate it with root of the project (code doing that). I don't understand why you have it repeated for different directories. That's why it might make sense to report it in https://community.sonarsource.com/ |
Thanks to your suggestion about relative paths, I've tried again using However the original problem with spamming the logs is still present. I've updated my initial description to make it clearer what the problem is. Out of 62 projects in my build, only 3 emit |
Any updates on this? @vilchik-elena |
Same here. Spaming the output is pretty annyoing/misleading |
we have added many rules from core eslint and some plugins, is this still a problem? |
Yes. I have custom rules, other plugins that I want to bring in. Op 19 okt 2023 om 16:07 heeft Ilia Kebets ***@***.***> het volgende geschreven:
we have added many rules from core eslint and some plugins, is this still a problem?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
The log severity has indeed been dropped from error to warn, but we still get a stacktrace as can also be seen in the original poster's logs. Please remove this stacktrace. |
Issue:
I have a solution (MSBuild) that builds 62 projects. Only 3 of those projects contain JavaScript / TypeScript. I want to import Eslint reports into SonarQube, to have a unified way of code quality reporting. However I'm blocked in doing so as SonarScanner will report 59 errors while scanning. It tries to import eslint's report for all projects, even though most projects don't emit eslint reports. This produces a lot of errors, which makes it hard to find any real errors within the pile of errors generated by SonarScanner.
Expected result: don't print errors if no report is found
Actual result: output is littered with "errors"
My version:
Build: MSBuild on Azure Devops
Configuration:
Logs:
The text was updated successfully, but these errors were encountered: