Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S6544 (no-misused-promises): Set checkVoidReturn.arguments=false and improve message for conditionals #4519

Closed
ilia-kebets-sonarsource opened this issue Jan 24, 2024 · 0 comments · Fixed by #4561
Closed

Fix FP S6544 (no-misused-promises): Set checkVoidReturn.arguments=false and improve message for conditionals #4519

ilia-kebets-sonarsource opened this issue Jan 24, 2024 · 0 comments · Fixed by #4561
Labels
mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934
Milestone
10.12

Comments

@ilia-kebets-sonarsource
Copy link
Contributor

Improve message for the checkConditionals, mentioning that if you indeed want to check that the variable is initialized, you can explicit the check with a === undefined.

Add checkVoidReturn.arguments = false setting, It should take care of:

  • Event emitter callbacks
  • Express handlers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934
Projects
None yet
Milestone
10.12
Development

Successfully merging a pull request may close this issue.

Fix FP S6544 (no-misused-promises) - Set checkVoidReturn.arguments=false SonarSource/SonarJS
3 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource @ericmorand-sonarsource