Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S1186: also inspect empty set and init and empty local functions #3753

Closed
andrei-epure-sonarsource opened this issue Nov 16, 2020 · 0 comments · Fixed by #8584
Closed

S1186: also inspect empty set and init and empty local functions #3753

andrei-epure-sonarsource opened this issue Nov 16, 2020 · 0 comments · Fixed by #8584
Assignees
@antonioaversa
Labels
Sprint: Hardening Fix FPs/FNs/improvements
Milestone
9.19

Comments

@andrei-epure-sonarsource
Copy link
Contributor

andrei-epure-sonarsource commented Nov 16, 2020 •
edited by antonioaversa
Loading

Rule S1186 (EmptyMethod S1186) currently looks only at method bodies, and doesn't raise when seeing empty set or init (for C# 9).

It would make sense to raise on

  • empty set and init as these are actually void methods as well.
  • empy local functions

Remark: add and remove for events are both void, and empty method detection can be done for those too. A dedicated issue exists: #8599
Merged
@andrei-epure-sonarsource andrei-epure-sonarsource changed the title S1186: also inspect empty set and init S1186: also inspect empty set and init and empty local functions Nov 16, 2020
@antonioaversa antonioaversa added the Sprint: Hardening Fix FPs/FNs/improvements label Jan 22, 2024
@antonioaversa antonioaversa added this to the 9.18 milestone Jan 22, 2024
@antonioaversa antonioaversa mentioned this issue Jan 23, 2024
Merged
@antonioaversa antonioaversa mentioned this issue Jan 24, 2024
Open
@antonioaversa antonioaversa removed this from the 9.18 milestone Jan 26, 2024
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource added this to the 9.19 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonioaversa antonioaversa

Labels
Sprint: Hardening Fix FPs/FNs/improvements
Projects
None yet
Milestone
9.19
Development

Successfully merging a pull request may close this issue.

S1186: also inspect empty set and init and empty local functions SonarSource/sonar-dotnet
5 participants
@antonioaversa @andrei-epure-sonarsource @costin-zaharia-sonarsource @cristian-ambrosini-sonarsource @sebastien-marichal