Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule S5773: Types allowed to be deserialized should be restricted - VB.NET implementation #7565

Closed
5 tasks
Tim-Pohlmann opened this issue Jul 10, 2023 · 0 comments · Fixed by #7623
Closed
5 tasks

New Rule S5773: Types allowed to be deserialized should be restricted - VB.NET implementation #7565

Tim-Pohlmann opened this issue Jul 10, 2023 · 0 comments · Fixed by #7623
Assignees
@zsolt-kolbay-sonarsource
Labels
Area: CFG/SE CFG and SE related issues. Area: Security Related to Vulnerability and Security Hotspot rules Area: VB.NET VB.NET rules related issues. Type: New Rule Implementation for a rule that HAS been specified.
Milestone
9.6

Comments

@Tim-Pohlmann
Copy link
Contributor

Tim-Pohlmann commented Jul 10, 2023 •
edited
Loading

Once HashesShouldHaveUnpredictableSalt is migrated to the new SE engine, implement the VB.NET version of the rule:

  • Create VB.NET test cases (based on the C# test cases)
  • Set ShouldExecute to always return true
  • Modify rule logic if necessary to accommodate VB.NET test cases
  • Update ITs
  • Implement ShouldExecute for VB.NET
@Tim-Pohlmann Tim-Pohlmann added Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues. Area: Security Related to Vulnerability and Security Hotspot rules Type: New Rule Implementation for a rule that HAS been specified. Sprint: SE labels Jul 10, 2023
@Tim-Pohlmann Tim-Pohlmann added this to the 9.6 milestone Jul 11, 2023
Merged
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource linked a pull request Jul 20, 2023 that will close this issue
S5773: VB.NET implementation #7623
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource

Labels
Area: CFG/SE CFG and SE related issues. Area: Security Related to Vulnerability and Security Hotspot rules Area: VB.NET VB.NET rules related issues. Type: New Rule Implementation for a rule that HAS been specified.
Projects
None yet
Milestone
9.6
Development

Successfully merging a pull request may close this issue.

S5773: VB.NET implementation SonarSource/sonar-dotnet
3 participants
@Tim-Pohlmann @mary-georgiou-sonarsource @zsolt-kolbay-sonarsource