Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileMetadataAnalyzer and UtilityAnalyzerBase should use IsGenerated from SyntaxTreeExtensions #7858

Closed
csaba-sagi-sonarsource opened this issue Aug 23, 2023 · 0 comments · Fixed by #8395
Closed

FileMetadataAnalyzer and UtilityAnalyzerBase should use IsGenerated from SyntaxTreeExtensions #7858

csaba-sagi-sonarsource opened this issue Aug 23, 2023 · 0 comments · Fixed by #8395
Assignees
@martin-strecker-sonarsource
Labels
Type: Performance It takes too long.
Milestone
9.15

Comments

@csaba-sagi-sonarsource
Copy link
Contributor

FileMetadataAnalyzer and UtilityAnalyzerBase should use IsGenerated from SyntaxTreeExtensions since that one has caching implemented.
Currently, in both places, there are calls to the GeneratedCodeRecognizer directly, hence the logic is implemented multiple times instead of taking advantage of the caching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Type: Performance It takes too long.
Projects
None yet
Milestone
9.15
Development

Successfully merging a pull request may close this issue.

FileMetadataAnalyzer: Use tree.IsGenerated extension method SonarSource/sonar-dotnet
3 participants
@csaba-sagi-sonarsource @martin-strecker-sonarsource @sebastien-marichal