Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightupHelpers CanWrapNode, CanWrapObject and CanWrapOperation are performance sensitive #8106

Closed
martin-strecker-sonarsource opened this issue Sep 28, 2023 · 0 comments · Fixed by #8107
Closed

LightupHelpers CanWrapNode, CanWrapObject and CanWrapOperation are performance sensitive #8106

martin-strecker-sonarsource opened this issue Sep 28, 2023 · 0 comments · Fixed by #8107
Assignees
@martin-strecker-sonarsource
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: Performance It takes too long.
Milestone
9.13

Comments

@martin-strecker-sonarsource
Copy link
Contributor

martin-strecker-sonarsource commented Sep 28, 2023 •
edited
Loading

All three methods are on the hot path and should avoid allocations. They are currently responsible for 239MB (of 24.381MB) allocations:

image
@martin-strecker-sonarsource martin-strecker-sonarsource added Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. Type: Performance It takes too long. labels Sep 28, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title LightupHelpers CanWrapNode and CanWrapOperation are performance sensitive LightupHelpers CanWrapNode, CanWrapOperation and CanWrapOperation are performance sensitive Sep 28, 2023
Merged
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title LightupHelpers CanWrapNode, CanWrapOperation and CanWrapOperation are performance sensitive LightupHelpers CanWrapNode, CanWrapObject and CanWrapOperation are performance sensitive Sep 28, 2023
Merged
@andrei-epure-sonarsource andrei-epure-sonarsource added this to the 9.13 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: Performance It takes too long.
Projects
None yet
Milestone
9.13
Development

Successfully merging a pull request may close this issue.

Avoid allocations in LightupHelpers.CanWrap... methods SonarSource/sonar-dotnet
2 participants
@andrei-epure-sonarsource @martin-strecker-sonarsource