Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass the Netlify CLI version #5

Open
what1s1ove opened this issue Oct 6, 2024 · 2 comments
Open

Add ability to pass the Netlify CLI version #5

what1s1ove opened this issue Oct 6, 2024 · 2 comments

Comments

@what1s1ove
Copy link

Hey! Thanks for creating such an awesome action!

I wanted to bring up an issue regarding the Netlify CLI. After the release of v17.36.2, it started having some problems (see details). The only current workaround is to downgrade the CLI to v17.36.1. Unfortunately, this means that anyone using this action for deployments is blocked until the Netlify team fixes the issue in future versions 🥲

@South-Paw
Copy link
Owner

I've also hit the same issue within a monorepo with the Netlify CLI.

I just checked out the workflows for that project as I recalled doing something to work around the issue... and it looks like I've pinned v15 explicitly in a npx command

- name: Deploy to Netlify
  run: npx --yes netlify-cli@15.11.0 deploy --json --prod --dir=apps/user/dist
  env:
    NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
    NETLIFY_SITE_ID: ${{ secrets.NETLIFY_SITE_ID }}

The downside being the command output is not being parsed nor made available by the step for other steps...

Adding a way to specify the cli package version would certainly be useful though 👍

@what1s1ove
Copy link
Author

what1s1ove commented Oct 15, 2024

output is not being parsed nor made available by the step for other steps...

Agreed! This is a reason why I decided to use this action 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants