Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Google Sheets with Commander Spellbook Backend JSON Api #375

Closed
22 tasks done
ldeluigi opened this issue Mar 9, 2023 · 2 comments
Closed
22 tasks done

Replacing Google Sheets with Commander Spellbook Backend JSON Api #375

ldeluigi opened this issue Mar 9, 2023 · 2 comments

Comments

@ldeluigi
Copy link
Member

ldeluigi commented Mar 9, 2023

  • Replace Google Sheets with the new commander spellbook backend API
    • Fetch combos (now called variants) from the bulk json endpoint, reformatting the data to fit the old combo data model
    • Re-route the bulk endpoint to a user friendly url
    • Remap old combo ids (integers) to new ones (strings) using the generated json map
    • Exploiting properly the new fields and information that the backend now provides within the bulk json api
      • Exploit the id field to identify combos in the URL
        • Keeping the backwards compatibility with pre-existing urls
      • Exploit card's oracle_id field to retrieve the best or most recent version/print of a card (more info at Scryfall docs and at Scryfall Collection Api)
      • Exploit card's zone_location and card_state fields to display information for each card
        • [MAYBE] with a better UI/UX than simple generated text on screen
      • Exploit variant's produces list of features to generate the result text information
      • Exploit the identity field of variants instead of computing it
      • Exploit the mana_needed field of variants
      • Exploit the other_prerequisites field of variants
      • Exploit the description field of variants
      • Exploit the legalities field of variants in order to check for variant's legality in supported formats
      • Exploit the spoiler field too
  • Reset the backend database (which currently is dummy-seeded) and import combos from google sheets to the backend
    • while editor's work is paused
    • deploy the frontend in production after user acceptance tests succeed
  • Use the random sort + variant query endpoint to find random combos and filter only combos legal in commander (as per Change Random Button to Not Show Banned Combos #443)
  • Update the advanced syntax page and the syntax guide as well
@ldeluigi ldeluigi changed the title Replacing Google Sheets with Commander Spellbook Backend Bulk JSON Api [TASK] Replacing Google Sheets with Commander Spellbook Backend Bulk JSON Api Mar 9, 2023
@crookedneighbor crookedneighbor transferred this issue from SpaceCowMedia/spellbook-client-next Mar 11, 2023
@ldeluigi ldeluigi changed the title [TASK] Replacing Google Sheets with Commander Spellbook Backend Bulk JSON Api Replacing Google Sheets with Commander Spellbook Backend Bulk JSON Api Mar 11, 2023
@GordonsKitchen GordonsKitchen pinned this issue Apr 4, 2023
@ldeluigi
Copy link
Member Author

ldeluigi commented Nov 2, 2023

Mockup for templates:
spellbook_mockup_templates

@ldeluigi
Copy link
Member Author

ldeluigi commented Nov 2, 2023

Mockup for variant grouping:
image

Mockup for EXAMPLES variant display:
image

@ldeluigi ldeluigi changed the title Replacing Google Sheets with Commander Spellbook Backend Bulk JSON Api Replacing Google Sheets with Commander Spellbook Backend JSON Api Jan 1, 2024
@ldeluigi ldeluigi closed this as completed Jan 8, 2024
@ldeluigi ldeluigi unpinned this issue Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant