Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue: Cannot save settings (and more) #138

Closed
FredG89 opened this issue Dec 22, 2019 · 40 comments
Closed

Issue: Cannot save settings (and more) #138

FredG89 opened this issue Dec 22, 2019 · 40 comments
Assignees
@Ephellon
Labels
bug this item causes errors that make the project unusable discussion open ended forum to keep some issues down duplicate this item is a repeat of another enhancement this item makes the project better in some way help-wanted outside assistance is recommended for this item wiki requests that can be added to the Wiki for future users

Comments

@FredG89
Copy link

FredG89 commented Dec 22, 2019 •
edited by Ephellon
Loading

  1. Save button does not work and the "skip" option on the managers does not allow toggle. In both Chrome and Firefox developer versions when using the downloadable add-ons.

  2. Whenever I open another page or navigate in another tab, the browser jumps back to the plugin page.

  3. The Chrome and Firefox store versions are the old versions that does not allow anything but Radarr and Couchpotato.
@FredG89 FredG89 added bug this item causes errors that make the project unusable enhancement this item makes the project better in some way help-wanted outside assistance is recommended for this item labels Dec 22, 2019
@Ephellon
Copy link
Collaborator

Version numbers please

@Ephellon Ephellon changed the title Can not save beta app settings in Firefox or Chrome Issue: Cannot save settings Dec 22, 2019
@Ephellon Ephellon added the beta this is in testing (BETA) and requires beta-testers (active feedback) label Dec 22, 2019
@Ephellon
Copy link
Collaborator

Ephellon commented Dec 22, 2019 •
edited
Loading

  1. Must click on the label element (colored item), not the text to toggle

  2. Elaborate please

  3. That's explained in the README and WIki Removed notice with update (SpaceK33z:master), will re-implement

@Ephellon Ephellon changed the title Issue: Cannot save settings Issue: Cannot save settings (and more) Dec 22, 2019
@FredG89
Copy link
Author

FredG89 commented Dec 22, 2019 •
edited by Ephellon
Loading

Here are the errors:

Error 1

Error 2

Error 3

Chrome 79.0.3945.88, Firefox 72.0b9. It shows a stop sign like image when hovering over the toggle. I've tried to take a snapshot of this, but none of my tools are picking up the mouse

Error

Error

If I have the Web-to-Plex extension installed. If I open a tab then go to a website, the browser opens another tab to the Web-to-Plex settings. If I click on a link inside a website, the browser either opens another tab to Web-to-Plex or it jumps back to the Web-to-Plex tab that's already open.

@Ephellon
Copy link
Collaborator

The tab is trying to get you to fill out the settings

@Ephellon
Copy link
Collaborator

On mobile, will reorient comments later

@Ephellon
Copy link
Collaborator

I'll rewrite the Wiki and/or setup instructions, but: settings must be tested before they are enabled (they are enabled automatically after testing is successful). The settings will nag you until you press the save button.

@Ephellon Ephellon added the wiki requests that can be added to the Wiki for future users label Dec 22, 2019
@FredG89
Copy link
Author

FredG89 commented Dec 22, 2019 •
edited
Loading

1
2
3
4

@Ephellon
Copy link
Collaborator

Press "test" now

@FredG89
Copy link
Author

FredG89 commented Dec 22, 2019

I did. It just reloads the Sonarr Storage Path and Quality Profile.

@Ephellon
Copy link
Collaborator

Yes. Now the "skip" button should work as intended. After you're done changing the settings, press "save"

@FredG89
Copy link
Author

FredG89 commented Dec 22, 2019

Still does not work and save does not work.

@FredG89
Copy link
Author

FredG89 commented Dec 22, 2019

If you would like, we can do a screen share session or I can take a video.

@Ephellon
Copy link
Collaborator

What's the extension version? Bottom right

@FredG89
Copy link
Author

FredG89 commented Dec 22, 2019

Version 4.1.0.22

@Ephellon
Copy link
Collaborator

Ephellon commented Dec 22, 2019 •
edited
Loading

Update to 4.1.1.8 (most recent)

@Ephellon
Copy link
Collaborator

Duplicate of #127

@Ephellon Ephellon marked this as a duplicate of #127 Dec 22, 2019
@Ephellon Ephellon added the duplicate this item is a repeat of another label Dec 22, 2019
@FredG89
Copy link
Author

FredG89 commented Dec 22, 2019

How exactly am I going to update? The links on the installation guide page are the current verison that I have installed. The extension webstores are still v3.4.

@Ephellon
Copy link
Collaborator

On the WIki (just changed), download the BETA ZIP version

@Ephellon Ephellon removed the wiki requests that can be added to the Wiki for future users label Dec 28, 2019
@FredG89
Copy link
Author

FredG89 commented Dec 28, 2019

So the application seems to save now but does not save the libraries and quality settings. Thus when I try to add something to download, it doesn't do anything. Is there something I can do to try and narrow down what's causing that?

@FredG89
Copy link
Author

FredG89 commented Dec 28, 2019

Disregard. It seems to work on most sites, just wasn't working on metacritic.com

@Ephellon
Copy link
Collaborator

Hi, just got your message. I'm not sure what you meant by your first comment:

So the application...

Did you mean:

"Does not save (quality) settings when trying to download"

@Ephellon
Copy link
Collaborator

Tested on metacritic, nothing out of the ordinary... probably just didn't load fully (metacritic is network intensive)

@Ephellon Ephellon mentioned this issue Dec 30, 2019
Open
@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020

Nothing posted for a few days, closing.

@Ephellon Ephellon closed this as completed Jan 4, 2020
@FredG89
Copy link
Author

FredG89 commented Jan 4, 2020

Ah sorry about that. It doesn't really work on Metacritic for me (doesn't parse the movie/show). On IMDB and Movieo it's gone from "Add" to "Modify" even if the show/movie is not in Radarr or Sonarr. Thanks for all your help. Any update when it will be added to the Chrome and Firefox stores?

@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020

Yes. Just updated. Send me some examples please

@Ephellon Ephellon reopened this Jan 4, 2020
@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020

Also, it's designed to go to "Modify [this item]" after engaging the button. You don't have to actually add the item

@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020 •
edited
Loading

Note: v3.4 has to be updated by hand (by installing a different extension). The links can be found on the README

@FredG89
Copy link
Author

FredG89 commented Jan 4, 2020

Also, it's designed to go to "Modify [this item]" after engaging the button. You don't have to actually add the item

So how do I add an item? Does it auto add?

@FredG89
Copy link
Author

FredG89 commented Jan 4, 2020

2020-01-04_2-19-12
2020-01-04_2-19-27

@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020 •
edited
Loading

Click the button to add. It can only look at 100 items (250 150 for released version with compression enabled) from each manager.

@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020

In your case, it seems to be outside the range of items it added

@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020

I'm not sure how to fix this, other than constantly asking the manger for every item every time a page loads

@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020

But, I could make an option to always check instead of caching

@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020

Hmm, with that, I could also bring back individual buttons (maybe?)

@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020

I'm going to go make a mock up, maybe have a testable version out tomorrow

@Ephellon

This comment has been minimized.

Sign in to view
@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020 •
edited
Loading

Added the ID Caching Mode option

image

In action... I have "Adolescence" on Radarr, but it's too far out of the list to be recognized

image

Enable ID Caching Mode (MIN)

image

@Ephellon Ephellon added discussion open ended forum to keep some issues down enhancement this item makes the project better in some way help-wanted outside assistance is recommended for this item wiki requests that can be added to the Wiki for future users labels Jan 4, 2020
@Ephellon
Copy link
Collaborator

Ephellon commented Jan 4, 2020

Will rename to something less confusing later

@Ephellon
Copy link
Collaborator

Added the ID Fetching Mode setting
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ephellon Ephellon

Labels
bug this item causes errors that make the project unusable discussion open ended forum to keep some issues down duplicate this item is a repeat of another enhancement this item makes the project better in some way help-wanted outside assistance is recommended for this item wiki requests that can be added to the Wiki for future users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FredG89 @Ephellon