Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching needs to be more robust #38

Closed
InStim opened this issue Mar 14, 2018 · 4 comments
Closed

Matching needs to be more robust #38

InStim opened this issue Mar 14, 2018 · 4 comments
Labels
bug this item causes errors that make the project unusable

Comments

@InStim
Copy link

InStim commented Mar 14, 2018

Title matching matches titles that aren't the movie but have shared text.

Visited "The Greatest Showman" on IMDB. https://www.imdb.com/title/tt1485796/

Extension adds an "On Plex" button to the page. That movie is not in our library. Click the On Plex button and get taken to "The Greatest Showman - Never Enough [Official Lyric Video]" that has been downloaded and in a local Music Videos library.

There are actually four music videos on the server with "The Greatest Showman" in the title. "The Greatest Showman - Never Enough [Official Lyric Video]" is neither the first nor last alphabetically or by date added. Unsure why that was the title was chosen to link to on the Plex server.

@SpaceK33z
Copy link
Owner

Hmm this will be hard to fix reliably. It already scopes the search of titles on a specific library type, so e.g. a library with the type "Other Videos" will not be searched. Are you using the library type "Movies" on purpose for music videos?

@InStim
Copy link
Author

InStim commented Mar 18, 2018

Our Music Videos library is Type Other Videos not Movies. Scanner Plex Video Files Scanner, and Agent Personal Media.

@SpaceK33z SpaceK33z added the bug this item causes errors that make the project unusable label Mar 18, 2018
@SpaceK33z
Copy link
Owner

That is interesting because it should never search in a library with type "Other Videos", regardless of the scanner.

Note to self: these lines of code should perform the scoping.

@SpaceK33z
Copy link
Owner

Please test v3.3 (your browser should auto-update soon)!

This was referenced Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug this item causes errors that make the project unusable
Projects
None yet
Development

No branches or pull requests

2 participants