Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrooveApi #228

Closed
tofutim opened this issue Jul 1, 2016 · 3 comments
Closed

GrooveApi #228

tofutim opened this issue Jul 1, 2016 · 3 comments
Labels
Question

Comments

@tofutim
Copy link

tofutim commented Jul 1, 2016

Just wanted to say that this repo is inspirational. Thanks for writing it! I'm thinking about writing a GrooveApi and following your template.
@tofutim
Copy link
Author

tofutim commented Jul 1, 2016

I did have a question about your setup. When you are ready to switch to Is_Prerelease false how do you actually do it? I see $script_versionNumber.contains("-") but does something get changed in the GitVersionConfig for that to happen?

@tofutim
Copy link
Author

tofutim commented Jul 1, 2016

Looks like you just push a tag for say 1.0.0 to Is_Prerelease false. But now I am seeing

Patching AssemblyInfo
Patching src\GrooveApi\Properties\AssemblyInfo.cs...Wrong version format for assembly patching: 1.0.0.build.4036233

this is probably better in gitter. Sorry in advance.

@mozts2005
Copy link
Member

answered in gitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tofutim @mozts2005