Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument with OpenCensus #8

Closed
jkohen opened this issue Jun 6, 2018 · 5 comments
Closed

Instrument with OpenCensus #8

jkohen opened this issue Jun 6, 2018 · 5 comments
Labels
cleanup Internal cleanup

Comments

@jkohen
Copy link
Contributor

jkohen commented Jun 6, 2018

This is for monitoring the sidecar itself, not how we write the Prometheus data.

This is important so we don't rely on Prometheus to monitor the Prometheus sidecar (although that will be an option with OpenCensus).

https://opencensus.io/go/index.html

@jkohen
Copy link
Contributor Author

jkohen commented Jul 23, 2018

@fabxc you already started working on this.

@fabxc
Copy link
Contributor

fabxc commented Jul 24, 2018

All parts currently in functionality scope of OC should be migrated to it. Anything further depends on gauge support being added.

@wdhnl
Copy link

wdhnl commented Dec 8, 2018

OpenCensus now supports a view type of LastValue which is like a gauge https://godoc.org/go.opencensus.io/stats/view#LastValue

@jkohen
Copy link
Contributor Author

jkohen commented Dec 8, 2018

Thanks, Bill. We are working with OpenCensus to have a first-class gauge in Go soon, like it was added to Java https://github.com/census-instrumentation/opencensus-java/blob/master/api/src/main/java/io/opencensus/metrics/LongGauge.java

@jkohen jkohen assigned jkohen and unassigned fabxc Jan 4, 2019
@jkohen jkohen removed their assignment May 20, 2019
@jkohen jkohen added the cleanup Internal cleanup label Jul 30, 2019
@jkohen
Copy link
Contributor Author

jkohen commented Jul 30, 2019

This is a cleanup. We'll take care of this if necessary, but currently it's not a blocker, so I'm closing the issue.

@jkohen jkohen closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal cleanup
Projects
None yet
Development

No branches or pull requests

3 participants