Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on remove_dir_all 0.6 #129

Closed
dvtomas opened this issue Oct 6, 2020 · 6 comments · Fixed by #208
Closed

Depend on remove_dir_all 0.6 #129

dvtomas opened this issue Oct 6, 2020 · 6 comments · Fixed by #208

Comments

@dvtomas
Copy link

dvtomas commented Oct 6, 2020

I'm removing duplicate dependencies from my project, and remove_dir_all 0.5 (tempfile) vs 0.6 (others) is one of them

@Stebalien
Copy link
Owner

Note: This is currently blocked because remove_all_dirs 0.6+ adds a dependency on rayon, and I'm strongly against having a temporary file library launch new threads.

@messense
Copy link

messense commented Nov 5, 2022

Is remove_dir_all still needed? Cargo recently removed it and std::fs::remove_dir_all shows better performance: rust-lang/cargo#11333

@Xaeroxe
Copy link
Contributor

Xaeroxe commented Feb 24, 2023

Resolved in #207. Also, remove_dir_all no longer requires rayon.

@stanislav-tkach
Copy link

stanislav-tkach commented Feb 24, 2023

By the way, there is a race condition in old (<0.8.0) versions of the remove_dir_all library, so it would be nice to either update or remove this crate.

@Xaeroxe
Copy link
Contributor

Xaeroxe commented Feb 24, 2023

Changed my mind, switched to removing it in #208

@adumbidiot
Copy link

Was rust-lang/rust#29497 worked around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants