Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose SpooledData #300

Closed
AverageADF opened this issue Oct 23, 2024 · 2 comments · Fixed by #301
Closed

Expose SpooledData #300

AverageADF opened this issue Oct 23, 2024 · 2 comments · Fixed by #301

Comments

@AverageADF
Copy link
Contributor

Hello,
I see that the SpooledTempFile structure has a into_inner method that should allow us to retrieve the in-memory buffer / file object. However, I am unable to do anything with the value returned by this method as SpooledData is not exposed outside of the spooled module.

Do you think SpooledData could be exported in lib.rs? I can do a PR if you want.

Note: I would like to be able to use SpooledData for the same reasons as mentioned in this PR.
@Stebalien
Copy link
Owner

Hm. That seems like something clippy should lint about. Yes, I'd be happy to accept a PR to fix it.

@AverageADF AverageADF mentioned this issue Oct 23, 2024
Merged
@AverageADF
Copy link
Contributor Author

Here is the (very) small PR @Stebalien : #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: expose SpooledData enum AverageADF/tempfile
2 participants
@Stebalien @AverageADF