Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #14
I'm still not sure why we need this. But this is currently broken when we use a callback as the method does not uses the same arguments and would need to add, at least, the
search
method in the store since it's being called in the callback (and potentially others methods given to the users by Algolia|Meilisearch clients).Exemple of callback
See cbaconnier/laravel-scout-array-bug@cdb3620
I also mentioned in the issue, as alternative, we could store the callback(s) to allow the users to tests them separately.But I haven't got the time to investigate how to adapt the
Store
for this.What do you think?
Edit:
I don't think we can't add
assertSearchedWithCallback
test since we cannot compare closure.Or at least I have no knowledge of it.