-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pandas
or astropy.tables
in Lightcurve?
#91
Comments
But pandas does have some good functionalities (groupby etc ) , May be we should use both |
Tables fit better in Lightcurve and they also support grouping. I don't think necessary nor desirable including also pandas. |
Keep an eye on this astropy feature request for a time series module based on astropy tables: astropy/astropy-APEs#12 |
@dhuppenkothen @nithinsingh61 - Not sure if you've actually done something with this or not, but something that might be relevant: Astropy tables support conversion to/from pandas. So my thinking is that you might be better off having the "real" version be Astropy tables, because they support more complex data than pandas (e.g. times, coordinates), free metadata, and so on, but when you want pandas-compatible analysis tools/features, you can just do |
Hi, I've been playing around with Astropy tables and it really works well, including the Do we still want to use it for our Class objects ( |
@dhuppenkothen I think we should pin this and think about the use of Astropy's timeseries objects |
There was a suggestion today to use either
pandas
orastropy.tables
within theLightcurve
class.pandas
has the advantage that it has lots of functionality built-in.astropy.tables
has the advantage that it connects to other usefulastropy
concepts such as units and time concepts (which might allow us to provide time conversions more easily).Not something that needs to be fixed instantaneously, more a call for discussion.
The text was updated successfully, but these errors were encountered: