Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pandas or astropy.tables in Lightcurve? #91

Closed
dhuppenkothen opened this issue Mar 23, 2016 · 6 comments
Closed

Use pandas or astropy.tables in Lightcurve? #91

dhuppenkothen opened this issue Mar 23, 2016 · 6 comments
Labels
enhancement Improve existing functionality. help wanted We need additional help with these issues! question Question about functionality, usage, etc.

Comments

@dhuppenkothen
Copy link
Member

There was a suggestion today to use either pandas or astropy.tables within the Lightcurve class. pandas has the advantage that it has lots of functionality built-in.

astropy.tables has the advantage that it connects to other useful astropy concepts such as units and time concepts (which might allow us to provide time conversions more easily).

Not something that needs to be fixed instantaneously, more a call for discussion.

@dhuppenkothen dhuppenkothen added enhancement Improve existing functionality. help wanted We need additional help with these issues! question Question about functionality, usage, etc. labels Mar 23, 2016
@nithinsingh61
Copy link

  1. Pandas as in such doesn’t support fits and VOTable format(which are very relevant to us ),
  2. Column cant be multidimensional (if we wish wish to store data(say bispectrum viz (nfft,nfft) ) of a fixed time range or energy range Additions to Lightcurve class #90 ) we would fail
  3. Storing metadata (Additions to Lightcurve class #90) is not that flexible (Panda issue)

But pandas does have some good functionalities (groupby etc ) , May be we should use both pandas and astropy.tables?

@fustiman
Copy link

Tables fit better in Lightcurve and they also support grouping. I don't think necessary nor desirable including also pandas.

@abigailStev
Copy link
Member

Keep an eye on this astropy feature request for a time series module based on astropy tables: astropy/astropy-APEs#12

@eteq
Copy link

eteq commented Jun 21, 2016

@dhuppenkothen @nithinsingh61 - Not sure if you've actually done something with this or not, but something that might be relevant: Astropy tables support conversion to/from pandas.

So my thinking is that you might be better off having the "real" version be Astropy tables, because they support more complex data than pandas (e.g. times, coordinates), free metadata, and so on, but when you want pandas-compatible analysis tools/features, you can just do table.to_pandas() and use it as needed.

@evandromr
Copy link
Member

evandromr commented Apr 26, 2018

Hi,

I've been playing around with Astropy tables and it really works well, including the group_by method which makes binning really easy.

Do we still want to use it for our Class objects (Lightcurve, Crosspectrum, Powerspectrum) ? If so I can give this issue a shot.

ping @dhuppenkothen @matteobachetti

@matteobachetti
Copy link
Member

@dhuppenkothen I think we should pin this and think about the use of Astropy's timeseries objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality. help wanted We need additional help with these issues! question Question about functionality, usage, etc.
Projects
None yet
Development

No branches or pull requests

7 participants