Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style looks broken when using jQuery 3.5.0 #3148

Closed
ctrlaltca opened this issue Apr 15, 2020 · 5 comments
Closed

Style looks broken when using jQuery 3.5.0 #3148

ctrlaltca opened this issue Apr 15, 2020 · 5 comments
Assignees

Comments

@ctrlaltca
Copy link
Contributor

Hi, I recently composer-upgraded my php application and jQuery was upgraded from 3.4.x to 3.5.0. Now elFinder looks partially broken, like if the row height and columns width calculation are not performed correctly:

Schermata 2020-04-15 alle 20 51 36

I can easily reproduce this problem by chaging the jquery version from 3.4.1 to 3.5.0 in elfinder.legacy.html.

@nao-pon nao-pon self-assigned this Apr 16, 2020
@nao-pon
Copy link
Member

nao-pon commented Apr 16, 2020

@ctrlaltca I'll fix this. Thanks! 👍

ref. https://jquery.com/upgrade-guide/3.5/

@nao-pon
Copy link
Member

nao-pon commented Apr 16, 2020

I done. Please try to check with the nightly build.

@ctrlaltca
Copy link
Contributor Author

I can confirm it's working fine on the nightly build, thank you!

@SamMousa
Copy link

SamMousa commented May 6, 2020

For me it doesn't work with dev-master & jquery 3.5.0.

I have confirmed that my local history includes the required commit but it doesn't fix the issue.

@667bdrm
Copy link
Member

667bdrm commented May 23, 2020

I confirm that latest 2.1 branch has no ui issues on Drupal 9 which begin using jQuery 3.5.1 in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants