Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot skip checking for image convertion library #3167

Closed
sergejostir opened this issue May 23, 2020 · 1 comment
Closed

Cannot skip checking for image convertion library #3167

sergejostir opened this issue May 23, 2020 · 1 comment
Assignees

Comments

@sergejostir
Copy link
Contributor

if (($type === 'imagick' || $type === 'auto') && extension_loaded('imagick')) {
$this->imgLib = 'imagick';
} else if (($type === 'gd' || $type === 'auto') && function_exists('gd_info')) {
$this->imgLib = 'gd';
} else {
$convertCache = 'imgLibConvert';
if (($convertCmd = $this->session->get($convertCache, false)) !== false) {
$this->imgLib = $convertCmd;
} else {
$this->imgLib = ($this->procExec(ELFINDER_CONVERT_PATH . ' -version') === 0) ? 'convert' : '';
$this->session->set($convertCache, $this->imgLib);
}
}

There's no way to skip this check, if you do not have imagick or gd loaded. Could there be another condition added? I guess I'm not the only one that do not have any images to deal with.

@nao-pon
Copy link
Member

nao-pon commented May 31, 2020

@sergiz OK, I would add an option "none" which does not use the image library.

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants