Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated function buttonset() #3680

Open
fretzl opened this issue Oct 19, 2024 · 3 comments
Open

Deprecated function buttonset() #3680

fretzl opened this issue Oct 19, 2024 · 3 comments
Labels

Comments

@fretzl
Copy link

fretzl commented Oct 19, 2024

With jQuery v3.7.1 and jQuery UI v1.14.0 there is this persistent warning in the browser console each time elFinder initializes:

TypeError: n.find(...).buttonset is not a function

According to the docs (https://api.jqueryui.com/buttonset/) the function buttonset() has been deprecated since jQuery UI v1.12 and should be replaced by controlgroup().

The warning is indeed fixed by replacing a few occurrences of .buttonset() with .controlgroup() in elfinder.full.js and elfinder.min.js.

@dleffler
Copy link

E.g., 2 occurrences in searchbutton.js and rename.js?

@fretzl
Copy link
Author

fretzl commented Oct 20, 2024

No, in elfinder.full.js (lines 20426 and 31998) and consequently in elfinder.min.js

EDIT
I'm referring to the official elFinder-2.1.64 release.

Copy link

This issue is stale because it has been open for 50 days with no activity.

@github-actions github-actions bot added the stale label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@dleffler @fretzl and others