Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource.Embedder package requires github authentication to download #141

Open
Pietrodjaowjao opened this issue Mar 3, 2024 · 12 comments
Open
Labels
enhancement New feature or request

Comments

@Pietrodjaowjao
Copy link
Contributor

image
Translation: Mandatory proxy authentication

If i click cancel, it will just throw NU1301 for nuget.pkg.github.com/SubmergedAmongUs/index.json

@Pietrodjaowjao
Copy link
Contributor Author

Solution: Remove repo from nuget.config, then git clone Resource.Embedder into the csproj folder

@Alexejhero
Copy link
Member

Alexejhero commented Mar 3, 2024

Submerged uses a custom version of the Resource.Embedder package, which is hosted here on the GitHub package registry.

The GitHub package registry annoyingly requires you to sign in in order to download any packages. You have to enter your GitHub credentials there. If you are using two-factor authentication, then you need to generate a personal access token and use that as your password. This is then saved in your Windows Credential Manager. This is the same credential that is used when performing git operations from the command line (I am pretty sure), so if you're signed into git in the command line then I don't think this pop-up will occur.

image

@Alexejhero
Copy link
Member

Alexejhero commented Mar 3, 2024

I dislike this as well but I'm not sure what other alternatives there are. Maybe clone the Resource.Embedder package as a submodule, or get rid of it entirely from the codebase. I will think about it.

@Alexejhero Alexejhero changed the title Can't compile. Resource.Embedder package requires github authentication to download Mar 3, 2024
@Alexejhero Alexejhero added the enhancement New feature or request label Mar 3, 2024
@Pietrodjaowjao
Copy link
Contributor Author

maybe merge Resource.Embedder into the repo?

@AmongUsafk
Copy link

AmongUsafk commented Mar 3, 2024

Hi, I encountered this error yesterday, in Credential Manager Username Case I have to write my name from my github account or the token?

@Alexejhero
Copy link
Member

If you do NOT have two-factor authentication installed: enter your GitHub username and password
If you DO have two-factor authentication installed: Generate a personal access token by following this guide, enter your GItHub username in the username field and enter the personal access token instead of the password.

@AmongUsafk
Copy link

Thx ❤️

@AmongUsafk
Copy link

Is Possible to set that in a GitHub Codespace i use it a lot ? or i Need to use vs code desktop ?

@Alexejhero
Copy link
Member

If you use a GitHub Codespace, it probably uses git credential-manager instead of the Windows Credential Manager. Maybe look it up and see if you can set it up using that

@Pietrodjaowjao
Copy link
Contributor Author

@Alexejhero Resource.Embedder is not even used in the project at all

@Alexejhero
Copy link
Member

It is used, it's imported as a NuGet package.

@Pietrodjaowjao
Copy link
Contributor Author

i removed it and nothing changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants