You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm moving old project from hand-written logger to Serilog. As a temporary solution, some of old usages were replaced with such code:
Although, formally, analyzer is right (String.Empty is not a constant) and this is actually a bad practice, it is clear that this field will never contain anything other than empty string. Shouldn't String.Empty case be exceptional? (and, may be, separate code smell rule to warn about empty string template?)
The text was updated successfully, but these errors were encountered:
I'm moving old project from hand-written logger to Serilog. As a temporary solution, some of old usages were replaced with such code:
Although, formally, analyzer is right (
String.Empty
is not a constant) and this is actually a bad practice, it is clear that this field will never contain anything other than empty string. Shouldn'tString.Empty
case be exceptional? (and, may be, separate code smell rule to warn about empty string template?)The text was updated successfully, but these errors were encountered: