diff --git a/.changelog/3109.fixed.txt b/.changelog/3109.fixed.txt new file mode 100644 index 0000000000..68da5faa0a --- /dev/null +++ b/.changelog/3109.fixed.txt @@ -0,0 +1 @@ +fix(metrics-server): add double dashes to extra arguments \ No newline at end of file diff --git a/deploy/helm/sumologic/values.yaml b/deploy/helm/sumologic/values.yaml index b320e17438..7f80d291e6 100644 --- a/deploy/helm/sumologic/values.yaml +++ b/deploy/helm/sumologic/values.yaml @@ -1231,8 +1231,8 @@ metrics-server: apiService: create: true extraArgs: - - kubelet-insecure-tls=true - - kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname + - --kubelet-insecure-tls=true + - --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname ## Optionally specify image options for metrics-server # image: ## Optionally specify an array of imagePullSecrets. diff --git a/tests/helm/testdata/goldenfile/metric-server/basic.input.yaml b/tests/helm/testdata/goldenfile/metric-server/basic.input.yaml new file mode 100644 index 0000000000..81593b646e --- /dev/null +++ b/tests/helm/testdata/goldenfile/metric-server/basic.input.yaml @@ -0,0 +1,2 @@ +metrics-server: + enabled: true diff --git a/tests/helm/testdata/goldenfile/metric-server/basic.output.yaml b/tests/helm/testdata/goldenfile/metric-server/basic.output.yaml new file mode 100644 index 0000000000..d601bea191 --- /dev/null +++ b/tests/helm/testdata/goldenfile/metric-server/basic.output.yaml @@ -0,0 +1,85 @@ +# Source: sumologic/charts/metrics-server/templates/deployment.yaml +apiVersion: apps/v1 +kind: Deployment +metadata: + name: RELEASE-NAME-metrics-server + namespace: "sumologic" + labels: + app.kubernetes.io/name: metrics-server + helm.sh/chart: metrics-server-6.2.4 + app.kubernetes.io/instance: RELEASE-NAME + app.kubernetes.io/managed-by: Helm +spec: + replicas: 1 + selector: + matchLabels: + app.kubernetes.io/name: metrics-server + app.kubernetes.io/instance: RELEASE-NAME + strategy: + type: RollingUpdate + template: + metadata: + labels: + app.kubernetes.io/name: metrics-server + helm.sh/chart: metrics-server-6.2.4 + app.kubernetes.io/instance: RELEASE-NAME + app.kubernetes.io/managed-by: Helm + spec: + serviceAccountName: RELEASE-NAME-metrics-server + affinity: + podAffinity: + + podAntiAffinity: + preferredDuringSchedulingIgnoredDuringExecution: + - podAffinityTerm: + labelSelector: + matchLabels: + app.kubernetes.io/name: metrics-server + app.kubernetes.io/instance: RELEASE-NAME + topologyKey: kubernetes.io/hostname + weight: 1 + nodeAffinity: + + dnsPolicy: ClusterFirst + containers: + - name: metrics-server + image: docker.io/bitnami/metrics-server:0.6.2-debian-11-r0 + imagePullPolicy: "IfNotPresent" + securityContext: + readOnlyRootFilesystem: false + runAsNonRoot: true + runAsUser: 1001 + command: + - metrics-server + args: + - --secure-port=8443 + - --kubelet-insecure-tls=true + - --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname + env: + envFrom: + resources: + limits: {} + requests: {} + ports: + - name: https + containerPort: 8443 + livenessProbe: + failureThreshold: 3 + initialDelaySeconds: 0 + periodSeconds: 10 + successThreshold: 1 + timeoutSeconds: 1 + httpGet: + path: /livez + port: https + scheme: HTTPS + readinessProbe: + failureThreshold: 3 + initialDelaySeconds: 0 + periodSeconds: 10 + successThreshold: 1 + timeoutSeconds: 1 + httpGet: + path: /readyz + port: https + scheme: HTTPS