Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode and dar-mode not working and also further enhancement need #29

Closed
alok-mishra143 opened this issue Oct 19, 2024 · 11 comments
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request gssoc-ext GirlScript Summer of Code extended project hacktoberfest Hacktoberfest 2024 event project Level 2 GSSoC project Level 2

Comments

@alok-mishra143
Copy link
Contributor

Fix Light/Dark Mode Toggle & UI Enhancements

Summary

This PR addresses the following issues:

  • Fixes the non-functional light mode and dark mode toggle.
  • Improves the overall user experience with visual enhancements and additional features.

Changes Made

  1. Fixed Light/Dark Mode Toggle:

    • Corrected the logic for detecting the user’s theme preference and ensured smooth transitions between light and dark modes.
    • Updated the Tailwind CSS configuration to ensure proper theme application across the entire app.
    • Ensured all components correctly respond to the theme changes without visual glitches.
  2. Enhancements:

    • Improved Color Contrast: Enhanced the contrast in both light and dark modes to improve readability.
    • Animation Improvements: Added smoother transitions for elements when toggling between light and dark modes.
    • Mobile Responsiveness: Ensured that the theme toggle works seamlessly on mobile devices.
    • User Preferences: Added functionality to save the user's theme preference locally, so it persists across sessions.
@Suraj-kumar00 Suraj-kumar00 added bug Something isn't working enhancement New feature or request hacktoberfest Hacktoberfest 2024 event project gssoc-ext GirlScript Summer of Code extended project Level 2 GSSoC project Level 2 labels Oct 19, 2024
@Suraj-kumar00
Copy link
Owner

Hey @alok-mishra143 it yours!

Do remember you have 3 days to complete the issue!

And if you like the project please do consider to give the repo a star 🌟

@alok-mishra143
Copy link
Contributor Author

alok-mishra143 commented Oct 19, 2024

@Suraj-kumar00 i had completed my task but when i clone the it doesn`t show any code just empty folder then i download the zip and set that project but not able to push the code any suggestion what wrong happeing i add the remote origin and also checkout to branch

added.dark.mode.mp4

@Suraj-kumar00
Copy link
Owner

@Suraj-kumar00 i had completed my task but when i clone the it doesn`t show any code just empty folder then i download the zip and set that project but not able to push the code any suggestion what wrong happeing i add the remote origin and also checkout to branch

added.dark.mode.mp4

If you want we can connect over gmeet?

@alok-mishra143
Copy link
Contributor Author

hey.alokmishra@gmail.com

@alok-mishra143
Copy link
Contributor Author

image

@Suraj-kumar00
Copy link
Owner

image

I just update can you please pull the changes!

@alok-mishra143
Copy link
Contributor Author

The same error happened. Tomorrow, I will create the Notion document and send you what changes need to be made, so you can apply them directly :)

@Suraj-kumar00
Copy link
Owner

The same error happened. Tomorrow, I will create the Notion document and send you what changes need to be made, so you can apply them directly :)

From my side i just again cross checked all folders now don't have any space after their names can you please try again?

@alok-mishra143
Copy link
Contributor Author

yes now it solved

@Suraj-kumar00
Copy link
Owner

Hi @alok-mishra143, thanks for you contribution!

Can you see on the generate page this is not completely black! can you raise another pr by fixing this?

And if you like the project, can you please give the repo a star 🌟 !

image

@alok-mishra143
Copy link
Contributor Author

fixing that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request gssoc-ext GirlScript Summer of Code extended project hacktoberfest Hacktoberfest 2024 event project Level 2 GSSoC project Level 2
Projects
None yet
Development

No branches or pull requests

2 participants