This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Error for wrong type placeholders #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbe
changed the title
NachoSoto
reviewed
May 27, 2017
| do { | ||
| _ = try StringsFileParser.PlaceholderType.placeholders(fromFormat: "Text: %1$@; %1$ld.") | ||
| XCTFail("Code did parse string successfully while it was expected to fail for bad syntax") | ||
| } catch StringsFileParserError.invalidPlaceholder { |
AliSoftware
force-pushed
the
feature/error-for-wrong-type-placeholders
branch
from
d1d9d1b
to
d7578f2
Compare
AliSoftware
approved these changes
May 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws an error if placeholders in a format string (for the same position) have different types, for example:
Fixes SwiftGen/SwiftGen#309.