Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

Cleanup (remove) old stuff #5

Closed
djbe opened this issue Jan 4, 2017 · 5 comments
Closed

Cleanup (remove) old stuff #5

djbe opened this issue Jan 4, 2017 · 5 comments

Comments

@djbe
Copy link
Member

djbe commented Jan 4, 2017

Refs: SwiftGen/SwiftGen#244

Colors

  • enumName: has been replaced by param.enumName, should provide default value.
  • rgb and rgba (for each color): can be composed from the other components.

Fonts

  • enumName: has been replaced by param.enumName, should provide default value.
  • fontName (for each font): has been replaced by the name property.

Images

  • enumName: has been replaced by param.enumName, should provide default value.
  • images: just old, catalogs contains the structured information.

Storyboards

  • extraImports: replaced by modules (Parse storyboard customModule property SwiftGen#243)
  • sceneEnumName: has been replaced by param. sceneEnumName, should provide default value.
  • segueEnumName: has been replaced by param. segueEnumName , should provide default value.template using Stencil.
  • For each scene:
    • isBaseViewController: removed. You can replace it with a test for baseType == "ViewController".

Strings

  • enumName: has been replaced by param.enumName, should provide default value.
  • strings and structuredStrings: replaced by tables array, where each table has a structured levels property.
  • tableName: replaced by tables array, where each table has a name property.
  • for each level:
    • subenums: renamed to children.
  • for each string:
    • keytail: renamed to name.
    • params structure with the names, typednames, types, count and declarations arrays: removed.
    • These have been replaced by types which is an array of types. The previous variables
      can now be reconstructed using template tags now that Stencil has become more powerful.
@djbe
Copy link
Member Author

djbe commented Jan 16, 2017

Note: the templates have all ben refactored to not use these properties anymore. The only remaining change that hasn't been done yet (in the templates) is to use params as an array instead of params.types.

@djbe
Copy link
Member Author

djbe commented Feb 23, 2017

Added some more deprecated variables (and their replacements), see PR #13. Will add the new documentation to the wiki.

@AliSoftware
Copy link
Contributor

New depreciation to add: the fontName could be renamed just name for consistency?

@djbe
Copy link
Member Author

djbe commented Apr 21, 2017

Sure, I'll make a PR for this later.

@djbe
Copy link
Member Author

djbe commented May 8, 2017

With the release of 1.1.0, we can now delete all these variables 🎉

@djbe djbe reopened this May 8, 2017
@djbe djbe modified the milestones: 2.0.0, 1.1.0 May 8, 2017
@djbe djbe closed this as completed in #35 May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants