From 62e7615d662cc801b5145f23db11ede5dca65bc1 Mon Sep 17 00:00:00 2001 From: David Jennes Date: Sun, 13 Aug 2017 18:41:16 +0200 Subject: [PATCH] xcode 9 project changes + execute lint step using bundler --- CHANGELOG.md | 4 +++- Templates.xcodeproj/project.pbxproj | 16 ++++++++++++++-- .../xcschemes/Generate Output.xcscheme | 4 +++- .../xcshareddata/xcschemes/Tests.xcscheme | 4 +++- 4 files changed, 23 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3395e07..3684b09 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,7 +18,9 @@ _None_ ### Internal Changes -_None_ +* Ensure `swiftlint` is run using `bundler`. + [David Jennes](https://github.com/djbe) + [#46](https://github.com/SwiftGen/templates/pull/66) ## 2.0.0 diff --git a/Templates.xcodeproj/project.pbxproj b/Templates.xcodeproj/project.pbxproj index d4826f8..ac59f45 100644 --- a/Templates.xcodeproj/project.pbxproj +++ b/Templates.xcodeproj/project.pbxproj @@ -145,7 +145,7 @@ isa = PBXProject; attributes = { LastSwiftUpdateCheck = 0800; - LastUpgradeCheck = 0800; + LastUpgradeCheck = 0900; ORGANIZATIONNAME = SwiftGen; TargetAttributes = { 09A87B4F1BCCA2C600D9B9F5 = { @@ -216,7 +216,7 @@ ); runOnlyForDeploymentPostprocessing = 0; shellPath = /bin/sh; - shellScript = "if [[ ! $CI ]]; then\n rake lint:tests\n rake lint:output\nfi"; + shellScript = "if [[ ! $CI ]]; then\n [[ -r ~/.profile ]] && source ~/.profile\n [[ `which rbenv` ]] && eval \"$(rbenv init - --no-rehash sh)\"\n if [[ `which bundler` ]]; then\n bundle exec rake lint:tests\n bundle exec rake lint:output\n else\n echo \"warning: bundler not found, can't lint code. Please install bundler then run bundle install.\"\n fi\nfi"; }; DE127EA8748200EF28090721 /* [CP] Embed Pods Frameworks */ = { isa = PBXShellScriptBuildPhase; @@ -283,14 +283,20 @@ CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; CLANG_ENABLE_OBJC_ARC = YES; + CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; CLANG_WARN_BOOL_CONVERSION = YES; + CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; + CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; + CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; + CLANG_WARN_STRICT_PROTOTYPES = YES; CLANG_WARN_SUSPICIOUS_MOVE = YES; CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; @@ -329,14 +335,20 @@ CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; CLANG_ENABLE_OBJC_ARC = YES; + CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; CLANG_WARN_BOOL_CONVERSION = YES; + CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; + CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; + CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; + CLANG_WARN_STRICT_PROTOTYPES = YES; CLANG_WARN_SUSPICIOUS_MOVE = YES; CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; diff --git a/Templates.xcodeproj/xcshareddata/xcschemes/Generate Output.xcscheme b/Templates.xcodeproj/xcshareddata/xcschemes/Generate Output.xcscheme index 6690119..c8b84ed 100644 --- a/Templates.xcodeproj/xcshareddata/xcschemes/Generate Output.xcscheme +++ b/Templates.xcodeproj/xcshareddata/xcschemes/Generate Output.xcscheme @@ -1,6 +1,6 @@