Reorganize templates in subdirectories #13
Conversation
djbe
force-pushed
the
feature/templates-in-subdirectories
branch
from
c524eaf
to
73d7e99
Compare
djbe
force-pushed
the
feature/templates-in-subdirectories
branch
from
73d7e99
to
9229605
Compare
djbe
force-pushed
the
feature/templates-in-subdirectories
branch
from
5cef97e
to
cec3634
Compare
djbe
force-pushed
the
feature/templates-in-subdirectories
branch
from
cec3634
to
922e0c9
Compare
|
@AliSoftware this is the subdir PR that I mentioned. The only thing it does is move the templates, and modify the testing code to handle these changes. The only annoyance remains the iOS/macOS storyboards thing. Eventually I'd like to somehow merge these two, they are quite similar. But that'd be something for another issue/PR. |
|
Renaming |
There was a problem hiding this comment.
LGTM (as long as the renaming of default will be handled in a separate PR).
But we should definitely test running rake cli:install['~/Desktop/SGTest'] (after checkout-ing the appropriate branches for this PR and the one in SwiftGen), then test the local install with a named template, to ensure it finds it as expected. Haven't had time to test that on a Mac yet to fully validate this PR pair.
|
The swiftgen branch already points to this one, and I just tried the install, it works correctly. |
|
Regarding your default->swift2 comment, yeah, I'm splitting everything up in small(-ish) steps. |
Fixes #1.
Needs modifications in the swiftgen CLI code.