This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Strings: multiple tables support #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbe
changed the title
djbe
force-pushed
the
feature/strings-multiple-tables
branch
from
42ea6f8
to
24a12d7
Compare
AliSoftware
approved these changes
May 27, 2017
AliSoftware
force-pushed
the
feature/strings-multiple-tables
branch
from
24a12d7
to
e610d2f
Compare
|
@djbe Rebased but with conflicts so I'll let you double-check before merging |
|
Didn't we forget the CHANGELOG entry again? |
|
I did |
This was referenced Aug 1, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts both the structured and flat templates to use the table information correctly. The templates will only generate a subenum if there's more than one table.
I've also adapted the flat template to use static constants instead of cases, as discussed during one of the slack conversations. Can I leave it in this PR, or should I split that change off into it's own PR?
Refs SwiftGen/SwiftGenKit#41