Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a save function to the session sidecar #1175

Closed
olevski opened this issue Jul 20, 2022 · 4 comments · Fixed by #1219
Closed

Add a save function to the session sidecar #1175

olevski opened this issue Jul 20, 2022 · 4 comments · Fixed by #1219
Assignees

Comments

@olevski
Copy link
Member

olevski commented Jul 20, 2022

This can be used by the ui to save unsaved work in a user's session when a user tries to shut down a session that has unsaved work.

@olevski olevski moved this to Backlog in renku-python Jul 20, 2022
@olevski
Copy link
Member Author

olevski commented Jul 20, 2022

This would run git add, commit and push.

Alternatively we can also install the renku-cli in the git sidecar and use renku save for this purpose.

@Panaetius Panaetius moved this from Backlog to Ready in renku-python Jul 26, 2022
@andre-code
Copy link

Please also include the Refresh function.
Ref: SwissDataScienceCenter/renku-ui#1956

@olevski
Copy link
Member Author

olevski commented Aug 4, 2022

@andre-code #1196 is for "refresh"/git pull

@ciyer
Copy link
Contributor

ciyer commented Aug 6, 2022

The implementation will require a bit more than just renku save. It will need to do the following:

- git fetch
- git status --porcelain --branch: Should return that checkout is at or ahead of upstream, if not fail
- renku save

The second command should provide user-understandable feedback as to why the save couldn't run if it fails at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants