From ae60afd13815492728cb6026b822353552cd6c23 Mon Sep 17 00:00:00 2001
From: Lorenzo <lorenzo.cavazzi.tech@gmail.com>
Date: Wed, 2 Oct 2024 15:51:38 +0200
Subject: [PATCH] fixes from review (part 1)

* Add provider button text
* Connected serivces page button color
* italics text
---
 .../admin/AddConnectedServiceButton.tsx       |  2 +-
 .../admin/ConnectedServicesSection.tsx        | 24 ++++++-------------
 .../ConnectedServicesPage.tsx                 |  2 +-
 3 files changed, 9 insertions(+), 19 deletions(-)

diff --git a/client/src/features/admin/AddConnectedServiceButton.tsx b/client/src/features/admin/AddConnectedServiceButton.tsx
index 341d043d7..c67f851ba 100644
--- a/client/src/features/admin/AddConnectedServiceButton.tsx
+++ b/client/src/features/admin/AddConnectedServiceButton.tsx
@@ -49,7 +49,7 @@ export default function AddConnectedServiceButton() {
     <>
       <Button className="btn-outline-rk-green" onClick={toggle}>
         <PlusLg className={cx("bi", "me-1")} />
-        Add Session Environment
+        Add Service Provider
       </Button>
       <AddConnectedServiceModal isOpen={isOpen} toggle={toggle} />
     </>
diff --git a/client/src/features/admin/ConnectedServicesSection.tsx b/client/src/features/admin/ConnectedServicesSection.tsx
index a0e5eaa6f..44eb8798b 100644
--- a/client/src/features/admin/ConnectedServicesSection.tsx
+++ b/client/src/features/admin/ConnectedServicesSection.tsx
@@ -130,27 +130,17 @@ function ConnectedService({ provider }: ConnectedServiceProps) {
 
         <Collapse isOpen={isOpen}>
           <CardBody className="pt-0">
+            <CardText className="mb-2">ID: {provider.id}</CardText>
+            <CardText className="mb-2">Kind: {provider.kind}</CardText>
+            <CardText className="mb-2">URL: {provider.url}</CardText>
             <CardText className="mb-2">
-              ID: <i>{provider.id}</i>
+              Client ID: {provider.client_id}
             </CardText>
             <CardText className="mb-2">
-              Kind: <i>{provider.kind}</i>
-            </CardText>
-            <CardText className="mb-2">
-              URL: <i>{provider.url}</i>
-            </CardText>
-            <CardText className="mb-2">
-              Client ID: <i>{provider.client_id}</i>
-            </CardText>
-            <CardText className="mb-2">
-              Client secret: <i>{provider.client_secret}</i>
-            </CardText>
-            <CardText className="mb-2">
-              Scope: <i>{provider.scope}</i>
-            </CardText>
-            <CardText>
-              Use PKCE: <i>{provider.use_pkce.toString()}</i>
+              Client secret: {provider.client_secret}
             </CardText>
+            <CardText className="mb-2">Scope: {provider.scope}</CardText>
+            <CardText>Use PKCE: {provider.use_pkce.toString()}</CardText>
           </CardBody>
 
           <CardFooter
diff --git a/client/src/features/connectedServices/ConnectedServicesPage.tsx b/client/src/features/connectedServices/ConnectedServicesPage.tsx
index 9fcf9123b..b6842682f 100644
--- a/client/src/features/connectedServices/ConnectedServicesPage.tsx
+++ b/client/src/features/connectedServices/ConnectedServicesPage.tsx
@@ -144,7 +144,7 @@ function ConnectButton({ connectionStatus, id }: ConnectButtonParams) {
     connectionStatus === "connected" ? "btn-outline-primary" : "btn-primary";
 
   return (
-    <a className={cx(color, "btn", "btn-secondary", "ms-auto")} href={url}>
+    <a className={cx(color, "btn", "ms-auto")} href={url}>
       {text}
     </a>
   );