fix: prevent crashes on lineage for short node labels #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI seems to crash on the lineage preview when a
labelproperty of a "ProcessRun" node doesn't contain any space. In the example provided in #1101, the command issbt.I modified the logic we use to derive the label we show in the graph. Now the output looks fine in most cases, but it can be improved for very long strings. One way would be providing more interactions, like popovers or tooltips for long commands.
I guess this is enough as a bugfix, but we may want to refactor the graph output later to provide a better UX (that would require a design and a deep overhaul).
Please test using different projects, I may very well have missed corner cases.
Preview: https://lorenzotest.dev.renku.ch/
fix #1101