Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datasets ordered by dates created #1240

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Conversation

vfried
Copy link
Contributor

@vfried vfried commented Feb 11, 2021

There was a bug in dataset search that was not ordering datasets per imported date.

I revised the way we handle dates in datasets to display it in a more accurate way.

Datasets Search
We get from the KG "date" we check if the dataset was published or not (we do this by checking if it has a datePublished or not) we display "Published date" or "Created date" and the date.

Dataset Display
For datasets inside projects:

  • Datasets created in renku: Inside projects we get created_at from the core service we map this to created
  • Imported datasets: we get datePublished from the KG and we use this since we get nothing from core

For datasets inside the kg (display from search)

  • Datasets created in renku have created
  • Imported datasets have published date

For datasets that are not in the KG(only inside projects):
We only get a date_created for datasets created in the KG so we display this (we map it to created)

Closes #1226

/deploy

@vfried vfried requested a review from a team as a code owner February 11, 2021 15:14
@vfried vfried temporarily deployed to renku-ci-ui-1240 February 11, 2021 15:34 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1240.dev.renku.ch

@vfried vfried temporarily deployed to renku-ci-ui-1240 February 12, 2021 08:41 Inactive
@vfried vfried force-pushed the 1226-orde-date-created-datasets branch from 335ffc4 to 98c0530 Compare February 16, 2021 08:26
@vfried vfried temporarily deployed to renku-ci-ui-1240 February 16, 2021 08:27 Inactive
@vfried vfried force-pushed the 1226-orde-date-created-datasets branch from 4a2e368 to f4f36ef Compare February 16, 2021 14:54
@vfried vfried temporarily deployed to renku-ci-ui-1240 February 16, 2021 14:54 Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised 👍

@vfried vfried merged commit 6153940 into master Feb 18, 2021
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@ciyer ciyer deleted the 1226-orde-date-created-datasets branch April 1, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order by date_published should be changed to order by date_created for datasets
3 participants